Fix race conditions in action client #1164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustelalande
requested review from
adityapande-1995 and
sloretz
as code owners
Signed-off-by: augustelalande <[email protected]>
Signed-off-by: augustelalande <[email protected]>
Signed-off-by: augustelalande <[email protected]>
Signed-off-by: augustelalande <[email protected]>
augustelalande
force-pushed
the
rolling
branch
from
dc82cf6 to
4247cb5
Compare
augustelalande
changed the title
Contributor
Author
|
@sloretz @adityapande-1995 any help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the race conditions described in #878, by implementing essentially the same solution as #871.
Additionally, I also implement #838 which was implemented in the regular client but not the action client.
The one thing it does not address is that
rclpy/rclpy/rclpy/executors.py
Lines 453 to 454 in 0a02395
can potentially execute without the future having been added to the list, in which case the future's callbacks will execute immediately instead of being delegated to the task queue.