Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions rclcpp/include/rclcpp/context.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -305,18 +305,21 @@ class Context : public std::enable_shared_from_this<Context>
std::type_index type_i(typeid(SubContext));
std::shared_ptr<SubContext> sub_context;
auto it = sub_contexts_.find(type_i);
if (it == sub_contexts_.end()) {
// It doesn't exist yet, make it
sub_context = std::shared_ptr<SubContext>(
new SubContext(std::forward<Args>(args) ...),
[](SubContext * sub_context_ptr) {
delete sub_context_ptr;
});
sub_contexts_[type_i] = sub_context;
} else {
if (it != sub_contexts_.end()) {
// It exists, get it out and cast it.
sub_context = std::static_pointer_cast<SubContext>(it->second);
auto sub_context_ptr = it->second.lock();
if (sub_context_ptr) {
return std::static_pointer_cast<SubContext>(sub_context_ptr);
}
}

// It doesn't exist yet, make it
sub_context = std::shared_ptr<SubContext>(
new SubContext(std::forward<Args>(args) ...),
[](SubContext * sub_context_ptr) {
delete sub_context_ptr;
});
sub_contexts_[type_i] = sub_context;
return sub_context;
}

Expand All @@ -338,7 +341,7 @@ class Context : public std::enable_shared_from_this<Context>
rclcpp::InitOptions init_options_;
std::string shutdown_reason_;

std::unordered_map<std::type_index, std::shared_ptr<void>> sub_contexts_;
std::unordered_map<std::type_index, std::weak_ptr<void>> sub_contexts_;
// This mutex is recursive so that the constructor of a sub context may
// attempt to acquire another sub context.
std::recursive_mutex sub_contexts_mutex_;
Expand Down