[Backport] Make TimeSource ignore use_sim_time events coming from other nodes (#799) #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…799) Signed-off-by: Michel Hidalgo <[email protected]>
Contributor
Author
|
Running CI on
|
ivanpauno
approved these changes
Jul 29, 2019
jacobperron
approved these changes
Jul 29, 2019
hidmic
changed the title
Contributor
Author
|
@nuclearsandwich PR job failed for apparently unrelated reasons. I cannot kick start it again. Should we? Or can we merge this already? |
Member
It doesn't look like an infrastructure failure. That test does appear to be flaky on the Dashing devel job. http://build.ros2.org/view/Ddev/job/Ddev__rclcpp__ubuntu_bionic_amd64/45/testReport/ I think merging is fine but if that test is not recorded as flaky anywhere it would be good to get an issue logged and spend some time 🔎. |
Contributor
Author
Contributor
Author
|
Ok, going in. We can track that test on |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Added benchmark test to rcl_yaml_param_parser Signed-off-by: ahcorde <[email protected]> * reset heap counters Signed-off-by: ahcorde <[email protected]> * updated benchmark tests Signed-off-by: ahcorde <[email protected]> * Added feedback Signed-off-by: ahcorde <[email protected]> * Replace BENCHMARK_DEFINE_F and BENCHMARK_REGISTER_F with BENCHMARK_F Signed-off-by: ahcorde <[email protected]> * Used rcpputils for the path Signed-off-by: ahcorde <[email protected]> * Clean up the CMake dependencies Signed-off-by: Scott K Logan <[email protected]> * Updated test Signed-off-by: ahcorde <[email protected]> * udpated test name Signed-off-by: ahcorde <[email protected]> Co-authored-by: Scott K Logan <[email protected]>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…sn't cleared (ros2#803) Signed-off-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michel Hidalgo [email protected]