Closed
Conversation
Member
Author
|
Member
Author
|
ivanpauno
approved these changes
Nov 3, 2020
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
I think you'll need to release https://github.com/ament/googletest/ in order to make the Rpr checker happy.
There are also some warning on macOS, it seems that -Wformat=2 is stricter in clang (the warnings seem to actually be a bug, so that's good).
LGTM with both things solved!
Contributor
|
@ros-pull-request-builder retest this please |
Contributor
(we already did that in rolling, so I just kicked the PR job again) |
audrow
force-pushed
the
audrow/rclcpp_components
branch
from
db5895e to
62c958b
Compare
Member
Author
|
These changes were already applied by #1442 - thus, zero commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
-Wformat=2,-Wconversion,-Wshadow,-Wsign-conversion,-Wold-style-cast, and-Wcast-qualinrclcpp_components. This PR relies on using gtest v1.10.0, see ament/googletest#8.