[foxy backport] Add executor unit tests #1336#1395
Merged
brawner merged 4 commits intobrawner/rclcpp-backport-tests-part1from Oct 9, 2020
Merged
[foxy backport] Add executor unit tests #1336#1395brawner merged 4 commits intobrawner/rclcpp-backport-tests-part1from
brawner merged 4 commits intobrawner/rclcpp-backport-tests-part1from
Conversation
brawner
changed the title
Contributor
Author
|
ahcorde
reviewed
Oct 9, 2020
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
cppcheck timeout on macos
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part6
branch
from
b8f69f5 to
34b79f0
Compare
In particular, make sure to use 'throw_from_rcl_error' as much as possible. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This will be needed by the executor tests. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
changed the base branch from
brawner/rclcpp-backport-tests-part6
to
brawner/rclcpp-backport-tests-part1
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part7
branch
from
6433853 to
d6f1f34
Compare
Contributor
Author
|
The timeout for cppcheck is set over at ament_lint, there is an open PR to increase its timeout. Let's see if it's ultimately required when I test the full feature branch on #1383 |
ahcorde
approved these changes
Oct 9, 2020
delete-merged-branch
bot
deleted the
brawner/rclcpp-backport-tests-part7
branch
brawner
added a commit
that referenced
this pull request
Oct 19, 2020
* Improve the error messages in the Executor class. In particular, make sure to use 'throw_from_rcl_error' as much as possible. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Allow mimick patching of methods with up to 9 arguments. This will be needed by the executor tests. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Add in unit tests for the Executor class. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Adjust test_executor for foxy Signed-off-by: Stephen Brawner <brawner@gmail.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #1336 for foxy. This will be squash merged into #1384, which will in turn be rebase and merged onto foxy.
Edit: I meant #1336 not #1331 (which likely won't be backported)