[foxy backport] Backport various unit tests part for coverage part 4-ish#1390
Merged
brawner merged 4 commits intobrawner/rclcpp-backport-tests-part1from Oct 7, 2020
Merged
Conversation
Contributor
Author
|
ahcorde
approved these changes
Oct 7, 2020
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
LGTM, just adding test files
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part3
branch
from
93f8947 to
fc83d32
Compare
…rs (#1322) * Increase coverage of node_interfaces, including with mocking rcl errors Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add basic tests context access * Add expected interrupt_guard get/release * Add mocking utilities to rclcpp * Add tests interrupt_guard_condition * Add tests ini/fini error context * Add destructor test error * Create context directly in block* Use scope exit to clean context Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Add coverage for missing API (except executors Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Do not check state Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase coverage of publisher/subscription API Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Feedback Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part4
branch
from
c803e13 to
e54e237
Compare
brawner
changed the base branch from
brawner/rclcpp-backport-tests-part3
to
brawner/rclcpp-backport-tests-part1
Contributor
Author
|
Rebase and merging onto #1383 so that can act as the ultimate feature branch. |
delete-merged-branch
bot
deleted the
brawner/rclcpp-backport-tests-part4
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the PRs for coverage. They are unchanged except for the commit for #1322, where I had to make a small change in
test_node_graph.cppfor API compatibility (count_graph_users()is not const in foxy)Coverage PRs: #1322, #1321, #1326, #1325