[foxy backport] Backports for init_options test (#1165, #1272)#1388
Merged
brawner merged 2 commits intobrawner/rclcpp-backport-tests-part1from Oct 7, 2020
Merged
Conversation
Contributor
Author
|
ahcorde
approved these changes
Oct 7, 2020
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part2
branch
from
f4ff384 to
def9730
Compare
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Remove non-foxy api changes Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
brawner
force-pushed
the
brawner/rclcpp-backport-1272
branch
from
be9139a to
4552f91
Compare
brawner
changed the base branch from
brawner/rclcpp-backport-tests-part2
to
brawner/rclcpp-backport-tests-part1
Contributor
Author
|
Rebase and merging onto #1383 so that PR can act as the ultimate feature branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the init_options test from #1165 and #1272. It does not include the API changes and excludes the get/set_domain_id unit test.