[foxy backport] Backport various commits for unit tests and coverage#1387
Merged
brawner merged 7 commits intobrawner/rclcpp-backport-tests-part1from Oct 7, 2020
Merged
Conversation
Contributor
Author
|
Testing
|
ahcorde
approved these changes
Oct 7, 2020
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
LGTM, just added new tests or new test files
brawner
force-pushed
the
brawner/rclcpp-backport-1222
branch
from
971190f to
e687f0f
Compare
* EXPECT_THROW_EQ and ASSERT_THROW_EQ macros for unittests Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address PR Feedback Signed-off-by: Stephen Brawner <brawner@gmail.com>
…#1189) * Unit tests for memory_strategy classes (part 1) Adds unit tests for: * strategies/message_pool_memory_strategy.hpp * memory_strategy.cpp * message_memory_strategy.cpp Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address PR Feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * Update with new macros Signed-off-by: Stephen Brawner <brawner@gmail.com>
…#1245) * fix node graph test with Connext and CycloneDDS returning actual data Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * use ADD_FAILURE() Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
) * fix failing test with Connext since it doesn't wait for discovery Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * Check for added service in the node graph Signed-off-by: Stephen Brawner <brawner@gmail.com> Co-authored-by: Stephen Brawner <brawner@gmail.com>
…1251) It turns out rmw_connext_cpp adds a default waitable that other rmw implementations do not. Adjusting the unit test to take this into account in a non-rmw specific manner. Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase timeouts for connext for long tests Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix cmakelists Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fix allocator memory strategy for connext Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Feedback Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part2
branch
from
f4ff384 to
def9730
Compare
brawner
changed the base branch from
brawner/rclcpp-backport-1222
to
brawner/rclcpp-backport-tests-part1
Contributor
Author
|
Rebase and merging into #1383 so that PR can act as the ultimate feature branch. |
delete-merged-branch
bot
deleted the
brawner/rclcpp-backport-tests-part2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports another chunk of PRs for unit test coverage. It also includes several test failure bug fixes.
Coverage PRs: #1221, #1189
New testing features: #1232
Bug fix PRs: #1245, #1246, #1251, #1253, #1252