[foxy backport] Derive and throw exception in spin_some spin_all for StaticSingleThreadedExecutor#1385
Merged
brawner merged 2 commits intobrawner/rclcpp-backport-tests-part1from Oct 7, 2020
Conversation
…adedExecutor (#1220) * Derive and throw exception in spin_some spin_all Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix style and add unit test Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Contributor
Author
|
@jacobperron @clalancette This is an older issue, but you both provided good feedback on the original PRs. |
jacobperron
approved these changes
Oct 6, 2020
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Looks okay to me. I'd like @clalancette to take a look too though.
Contributor
Author
|
clalancette
approved these changes
Oct 7, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Clever solution to maintain ABI.
Contributor
Author
|
I'm merging this into https://github.com/ros2/rclcpp/tree/brawner/rclcpp-backport-tests-part1 which will act as a feature branch, not into foxy directly yet. |
brawner
added a commit
that referenced
this pull request
Oct 19, 2020
…StaticSingleThreadedExecutor (#1385) * Derive and throw exception in spin_some spin_all for StaticSingleThreadedExecutor (#1220) * Derive and throw exception in spin_some spin_all Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix style and add unit test Signed-off-by: Stephen Brawner <brawner@gmail.com> * Remove header changes and throw exceptions in .cpp Signed-off-by: Stephen Brawner <brawner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #1229 in favor of a solution that doesn't affect ABI compatibility, but accomplishes a similar result.
Edit: This backports #1220 to foxy