Merged
Conversation
Update
pablogs9
force-pushed
the
feature/rclc_sleep_functionality
branch
from
bf798cd to
1d61902
Compare
Member
Author
|
BTW @JanStaschulat are you ok with forcing the policy of the PR to be always "Squash and merge" instead of just "Merge" to avoid having a tree like this one:
IMO in this image What do you think? |
Member
Author
|
Friendy ping @ralph-lange @JanStaschulat @norro |
JanStaschulat
approved these changes
Mar 26, 2021
Contributor
|
"Are you ok with including this functionality as part of the RCLC library?" @pablogs9 thanks for creating a file for the sleep function. Ralph suggested to create a pull request to Before merging, though, @norro please fix the error in rclc_lifecycle for rolling or create another issue, in which you resolve this. |
Member
Author
|
#66 is the fix. |
Collaborator
@JanStaschulat These errors are fixed separately with #66 |
Contributor
|
"BTW @JanStaschulat are you ok with forcing the policy of the PR to be always "Squash and merge" instead of just "Merge" to avoid having a tree like this one:" Yes, I agree. 'squash and merge' could be the default option. |
Member
Author
|
Updated default properties: |
JanStaschulat
pushed a commit
that referenced
this pull request
Mar 26, 2021
provide compatability for sleep function in Windows- and POSIX- operating systems.
JanStaschulat
pushed a commit
that referenced
this pull request
Mar 26, 2021
provide compatability for sleep function in Windows- and POSIX- operating systems. Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
pablogs9
added a commit
that referenced
this pull request
Apr 29, 2021
provide compatability for sleep function in Windows- and POSIX- operating systems.
pablogs9
added a commit
that referenced
this pull request
Apr 30, 2021
BrettRD
pushed a commit
to BrettRD/rclc
that referenced
this pull request
Jul 5, 2021
MiguelCompany
pushed a commit
to eProsima/rclc
that referenced
this pull request
Jun 6, 2023
* Updated changelog, version 0.1.6 Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * corrected changelog of rclc Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com> * increased version in package.xml files Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have had some incompatibility problems because we are forcing users to
#include <unistd.h>inexecutor.hand in some cross-compiled environments, this POSIX include is causing incompatibility errors.Are you ok with including this functionality as part of the RCLC library?