Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about number_of_handles #326

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Feb 3, 2023

Often developers are not aware to configure xrce-dds middleware also when initializing the Executor with number_of_handles.
I added docu in the README.md and executor.h

related issue: #325

Signed-off-by: Jan Staschulat <[email protected]>
@JanStaschulat JanStaschulat self-assigned this Feb 3, 2023
@JanStaschulat
Copy link
Contributor Author

@mergify backport humble foxy

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

backport humble foxy

✅ Backports have been created

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #326 (f553967) into master (361fcdf) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   69.20%   69.06%   -0.15%     
==========================================
  Files          16       16              
  Lines        2715     2715              
  Branches      765      765              
==========================================
- Hits         1879     1875       -4     
- Misses        450      452       +2     
- Partials      386      388       +2     
Impacted Files Coverage Δ
rclc/src/rclc/action_goal_handle.c 58.59% <0.00%> (-2.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jan Staschulat <[email protected]>
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JanStaschulat JanStaschulat merged commit 1d31f43 into master Feb 3, 2023
@JanStaschulat JanStaschulat deleted the feature/docu-number-of-handles branch February 3, 2023 13:57
mergify bot pushed a commit that referenced this pull request Feb 3, 2023
* updating documentation to configure maximum number_of_handles also in xrce-dds middleware

Signed-off-by: Jan Staschulat <[email protected]>

* typo

Signed-off-by: Jan Staschulat <[email protected]>

* added library include file name

Signed-off-by: Jan Staschulat <[email protected]>

---------

Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit 1d31f43)
mergify bot pushed a commit that referenced this pull request Feb 3, 2023
* updating documentation to configure maximum number_of_handles also in xrce-dds middleware

Signed-off-by: Jan Staschulat <[email protected]>

* typo

Signed-off-by: Jan Staschulat <[email protected]>

* added library include file name

Signed-off-by: Jan Staschulat <[email protected]>

---------

Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit 1d31f43)
JanStaschulat added a commit that referenced this pull request Feb 3, 2023
* updating documentation to configure maximum number_of_handles also in xrce-dds middleware

Signed-off-by: Jan Staschulat <[email protected]>

* typo

Signed-off-by: Jan Staschulat <[email protected]>

* added library include file name

Signed-off-by: Jan Staschulat <[email protected]>

---------

Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit 1d31f43)

Co-authored-by: Jan Staschulat <[email protected]>
JanStaschulat added a commit that referenced this pull request Feb 3, 2023
* updating documentation to configure maximum number_of_handles also in xrce-dds middleware

Signed-off-by: Jan Staschulat <[email protected]>

* typo

Signed-off-by: Jan Staschulat <[email protected]>

* added library include file name

Signed-off-by: Jan Staschulat <[email protected]>

---------

Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit 1d31f43)

Co-authored-by: Jan Staschulat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants