-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation about number_of_handles #326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… xrce-dds middleware Signed-off-by: Jan Staschulat <[email protected]>
Signed-off-by: Jan Staschulat <[email protected]>
@mergify backport humble foxy |
✅ Backports have been created
|
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
- Coverage 69.20% 69.06% -0.15%
==========================================
Files 16 16
Lines 2715 2715
Branches 765 765
==========================================
- Hits 1879 1875 -4
- Misses 450 452 +2
- Partials 386 388 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Jan Staschulat <[email protected]>
pablogs9
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
mergify bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
* updating documentation to configure maximum number_of_handles also in xrce-dds middleware Signed-off-by: Jan Staschulat <[email protected]> * typo Signed-off-by: Jan Staschulat <[email protected]> * added library include file name Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit 1d31f43)
mergify bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
* updating documentation to configure maximum number_of_handles also in xrce-dds middleware Signed-off-by: Jan Staschulat <[email protected]> * typo Signed-off-by: Jan Staschulat <[email protected]> * added library include file name Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit 1d31f43)
JanStaschulat
added a commit
that referenced
this pull request
Feb 3, 2023
* updating documentation to configure maximum number_of_handles also in xrce-dds middleware Signed-off-by: Jan Staschulat <[email protected]> * typo Signed-off-by: Jan Staschulat <[email protected]> * added library include file name Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit 1d31f43) Co-authored-by: Jan Staschulat <[email protected]>
JanStaschulat
added a commit
that referenced
this pull request
Feb 3, 2023
* updating documentation to configure maximum number_of_handles also in xrce-dds middleware Signed-off-by: Jan Staschulat <[email protected]> * typo Signed-off-by: Jan Staschulat <[email protected]> * added library include file name Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit 1d31f43) Co-authored-by: Jan Staschulat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often developers are not aware to configure xrce-dds middleware also when initializing the Executor with
number_of_handles
.I added docu in the
README.md
andexecutor.h
related issue: #325