Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dependency for package performance-test-fixture #245

Conversation

JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Feb 17, 2022

failing CI build in rclc on rolling: first failing build on https://github.com/ros2/rclc/runs/5136827515?check_suite_focus=true
resolves issue #246

CC: @norro

@JanStaschulat JanStaschulat self-assigned this Feb 17, 2022
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented Feb 17, 2022

@pablogs9 @ralph-lange @norro

When attempting to download the missing dependency ros-rolling-performance-test-fixture, user interaction is required and then the CI job stops. Any ideas, how to solve this?

 The following NEW packages will be installed:
  libbenchmark-dev libbenchmark1 ros-rolling-ament-cmake-google-benchmark
  ros-rolling-google-benchmark-vendor ros-rolling-performance-test-fixture
0 upgraded, 5 newly installed, 0 to remove and 6 not upgraded.
Need to get 313 kB of archives.
After this operation, 1,122 kB of additional disk space will be used.
Do you want to continue? [Y/n] Abort.
Error: Process completed with exit code 1.

https://github.com/ros2/rclc/runs/5229443757?check_suite_focus=true

@pablogs9
Copy link
Member

Maybe apt-get -y install [package]? The -y assumes yes to all user inputs. Also you have export DEBIAN_FRONTEND=noninteractive, check here

@norro
Copy link
Collaborator

norro commented Feb 17, 2022

apt-get -y in the CI file should do the trick (-y meaning "answer yes to everything")

@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented Feb 17, 2022

The most recent version of ros-tooling/action-ros-ci 0.2.3 changed exactly that to "noninteractive" mode. See this PR ros-tooling/action-ros-ci#701

Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
@JanStaschulat
Copy link
Contributor Author

Now the library ros2/mimick is missing.

   In file included from /__w/rclc/rclc/ros_ws/src/rcl/rcl_yaml_param_parser/test/test_parse.cpp:28:
  /__w/rclc/rclc/ros_ws/src/rcl/rcl_yaml_param_parser/test/./mocking_utils/patch.hpp:38:10: fatal error: mimick/mimick.h: No such file or directory
     38 | #include "mimick/mimick.h"

https://github.com/ros2/rclc/runs/5229849183?check_suite_focus=true

But I can't install it as usual with apt-get install ros-rolling-mimick

E: Unable to locate package ros-rolling-mimick
Error: Process completed with exit code 100.

https://github.com/ros2/rclc/runs/5230169797?check_suite_focus=true

Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #245 (a869ade) into master (ce42968) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          16       16           
  Lines        2149     2149           
  Branches      641      641           
=======================================
  Hits         1365     1365           
  Misses        471      471           
  Partials      313      313           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce42968...a869ade. Read the comment docs.

@JanStaschulat JanStaschulat merged commit 5bfb462 into master Feb 17, 2022
@JanStaschulat JanStaschulat deleted the bug/faild-build-on-rolling-missing-dependency-performance-test-fixture branch February 17, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants