Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum naming for avoid collision #242

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix enum naming for avoid collision #242

merged 1 commit into from
Feb 8, 2022

Conversation

@pablogs9
Copy link
Member Author

pablogs9 commented Feb 8, 2022

@mergify backport foxy galactic

@mergify
Copy link
Contributor

mergify bot commented Feb 8, 2022

backport foxy galactic

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@codecov-commenter
Copy link

Codecov Report

Merging #242 (8931eeb) into master (9c844f1) will decrease coverage by 0.18%.
The diff coverage is 86.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   63.61%   63.42%   -0.19%     
==========================================
  Files          16       16              
  Lines        2149     2149              
  Branches      641      641              
==========================================
- Hits         1367     1363       -4     
- Misses        470      472       +2     
- Partials      312      314       +2     
Impacted Files Coverage Δ
rclc/src/rclc/executor_handle.c 69.86% <53.84%> (ø)
rclc/src/rclc/executor.c 61.90% <95.65%> (ø)
rclc/src/rclc/action_goal_handle.c 59.87% <0.00%> (-2.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c844f1...8931eeb. Read the comment docs.

@pablogs9 pablogs9 merged commit ce42968 into master Feb 8, 2022
@pablogs9 pablogs9 deleted the fix/enum_naming branch February 8, 2022 10:52
mergify bot pushed a commit that referenced this pull request Feb 8, 2022
Signed-off-by: Pablo Garrido <[email protected]>
(cherry picked from commit ce42968)

# Conflicts:
#	rclc/include/rclc/executor_handle.h
#	rclc/src/rclc/executor.c
mergify bot pushed a commit that referenced this pull request Feb 8, 2022
Signed-off-by: Pablo Garrido <[email protected]>
(cherry picked from commit ce42968)

# Conflicts:
#	rclc/include/rclc/executor_handle.h
#	rclc/src/rclc/executor.c
@mergify
Copy link
Contributor

mergify bot commented Feb 8, 2022

backport foxy galactic

✅ Backports have been created

pablogs9 added a commit that referenced this pull request Feb 8, 2022
pablogs9 added a commit that referenced this pull request Feb 8, 2022
pablogs9 added a commit that referenced this pull request Feb 8, 2022
* Fix enum naming for avoid collision (#242)

Signed-off-by: Pablo Garrido <[email protected]>
(cherry picked from commit ce42968)

# Conflicts:
#	rclc/include/rclc/executor_handle.h
#	rclc/src/rclc/executor.c

* Revert "Fix enum naming for avoid collision (#242)"

This reverts commit 0166177.

* Update

Signed-off-by: Pablo Garrido <[email protected]>

Co-authored-by: Pablo Garrido <[email protected]>
pablogs9 added a commit that referenced this pull request Feb 8, 2022
* Fix enum naming for avoid collision (#242)

Signed-off-by: Pablo Garrido <[email protected]>
(cherry picked from commit ce42968)

# Conflicts:
#	rclc/include/rclc/executor_handle.h
#	rclc/src/rclc/executor.c

* Revert "Fix enum naming for avoid collision (#242)"

This reverts commit df482e3.

* Update

Signed-off-by: Pablo Garrido <[email protected]>

Co-authored-by: Pablo Garrido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants