Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix launch_testing output filtering #296

Merged
merged 4 commits into from
Aug 7, 2019
Merged

Fix launch_testing output filtering #296

merged 4 commits into from
Aug 7, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Aug 5, 2019

Precisely what the title says. A spin off from #279, as it's orthogonal to CLI testing.

@hidmic hidmic added the bug Something isn't working label Aug 5, 2019
ivanpauno
ivanpauno approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with green CI).

@hidmic
Copy link
Contributor Author

hidmic commented Aug 6, 2019 •
edited
Loading

CI (up to test_communication, test_rclcpp, launch_testing and launch_testing_ros):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Replace os.linesep with '\n'
e871168 
Signed-off-by: Michel Hidalgo <[email protected]>
@hidmic
Copy link
Contributor Author

hidmic commented Aug 7, 2019

Alright, going in !

@hidmic hidmic merged commit 6dc4e6e into master Aug 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-output-filtering branch August 7, 2019 17:09
piraka9011 pushed a commit to aws-ros-dev/launch that referenced this pull request Aug 16, 2019
@hidmic @piraka9011
Fix launch_testing output filtering (ros2#296)
251e9ea 
* Fix launch_testing output filtering.

Signed-off-by: Michel Hidalgo <[email protected]>

* Add test case for launch_testing.tools.basic_output_filter

Signed-off-by: Michel Hidalgo <[email protected]>

* Replace os.linesep with '\n'

Signed-off-by: Michel Hidalgo <[email protected]>

* Deal with all possible line boundaries.

Signed-off-by: Michel Hidalgo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidmic @ivanpauno