Skip to content

Humble "Backport" of #720 #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 18, 2024
Merged

Humble "Backport" of #720 #722

merged 6 commits into from
Dec 18, 2024

Conversation

@CursedRock17
Copy link
Contributor

@CursedRock17 CursedRock17 commented Oct 30, 2024

"Backport" of #720 in which we added .hpp versions of the .h files in tf2, but without the warning message to get backwards compatibility and prevent weird syntax like this:

#if __has_include(<cv_bridge/cv_bridge.hpp>)
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
#else
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
#endif

@CursedRock17 CursedRock17 changed the title Prioritizing C++ tf2 Headers Files Humble "Backport" of #720 Oct 30, 2024
@CursedRock17 CursedRock17 mentioned this pull request Oct 30, 2024
Merged
@CursedRock17
Adding Correct header
103038a 
Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17
Fixing Header Order
8e8c105 
Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17
Fixing Header Order
69d08ee 
Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17
Matching Linter
33dd734 
Signed-off-by: CursedRock17 <[email protected]>

Update Matrix3x3.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Matrix3x3.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update MinMax.h

Signed-off-by: Lucas Wendland <[email protected]>

Update MinMax.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update QuadWord.h

Signed-off-by: Lucas Wendland <[email protected]>

Update QuadWord.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update Quaternion.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Quaternion.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update Scalar.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Scalar.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update Transform.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Transform.hpp

Signed-off-by: Lucas Wendland <[email protected]>

Update Vector3.h

Signed-off-by: Lucas Wendland <[email protected]>

Update Vector3.hpp

Signed-off-by: Lucas Wendland <[email protected]>
@CursedRock17 CursedRock17 force-pushed the deprecate_tf2_headers_humble branch from 983d134 to 33dd734 Compare November 8, 2024 06:00
@CursedRock17
Reversing Order
f760a43 
Signed-off-by: CursedRock17 <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 18, 2024

Pulls: #722
Gist: https://gist.githubusercontent.com/ahcorde/4b96fc5bfd33655c38531b10a8253856/raw/b5a728235cb10dbf7994bd35160917a8c40d252c/ros2.repos
BUILD args: --packages-above-and-dependencies test_tf2 tf2 tf2_bullet tf2_eigen tf2_eigen_kdl tf2_geometry_msgs tf2_kdl tf2_py tf2_ros tf2_sensor_msgs --packages-above-and-dependencies test_tf2 tf2 tf2_bullet tf2_eigen tf2_eigen_kdl tf2_geometry_msgs tf2_kdl tf2_py tf2_ros tf2_sensor_msgs
TEST args: --packages-above test_tf2 tf2 tf2_bullet tf2_eigen tf2_eigen_kdl tf2_geometry_msgs tf2_kdl tf2_py tf2_ros tf2_sensor_msgs --packages-above test_tf2 tf2 tf2_bullet tf2_eigen tf2_eigen_kdl tf2_geometry_msgs tf2_kdl tf2_py tf2_ros tf2_sensor_msgs
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14979

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 299bbf3 into ros2:humble Dec 18, 2024
2 checks passed
@CursedRock17 CursedRock17 deleted the deprecate_tf2_headers_humble branch January 17, 2025 03:48
@wep21 wep21 mentioned this pull request Mar 26, 2025
Merged
@sloretz sloretz mentioned this pull request Jul 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@clalancette clalancette

Labels

backlog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CursedRock17 @ahcorde @clalancette @mjcarroll