Transform Data Callback Python #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CursedRock17 <[email protected]>
Signed-off-by: CursedRock17 <[email protected]>
clalancette
approved these changes
Apr 2, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
I think this is generally the correct thing to do here. I have a mild concern that this will cause some downstream code to break, but looking through all of the code released into rolling, nothing seems to use this in particular. I'm going to run CI on this, but @CursedRock17 can you please also open a PR to http://docs.ros.org/en/rolling/Releases/Release-Jazzy-Jalisco.html to add a note saying that we changed this?
Contributor
|
CI:
|
clalancette
requested changes
Apr 2, 2024
Signed-off-by: CursedRock17 <[email protected]>
clalancette
reviewed
Apr 2, 2024
Signed-off-by: CursedRock17 <[email protected]>
clalancette
approved these changes
Apr 3, 2024
Contributor
|
CI:
|
Signed-off-by: CursedRock17 <[email protected]>
Contributor
Author
|
The CI should still be fine, but I forgot to update the return value in the docs |
Contributor
|
I think this is good to go other than the addition to the release notes. Once that PR is open, I'll go ahead and merge this. |
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to resolve #194 as of right now I'm working off of PR #215. We need to change
_wait_for_transform_async, to return the transform data similar to the C++ version returning aTransformStampedFuture.