Conversation
| #define TF2ERROR_ENUM | ||
| enum class TF2Error : std::uint8_t { | ||
| NO_ERROR = 0, | ||
| NO_ERRORS = 0, |
There was a problem hiding this comment.
Not sure if this is a requirement but from my understanding, this should match the enums defined in the corresponding TF2Error ROS message
geometry2/tf2_msgs/msg/TF2Error.msg
Line 1 in fe1858c
For future references: This seems related to existing issues about windows defines: ros/geometry2#172 and ros2/rosidl#118.
There was a problem hiding this comment.
Thanks! I was blissfully unaware of that. Have pushed a fix to match the message and the enum.
There was a problem hiding this comment.
thanks! I'll leave it up to @tfoote to review the rest of this PR and comment on the best way to move forward regarding the enum names as he is the one that has the most context.
mikaelarguedas
added
in progress
|
Hi @bfjelds, it looks like ther has been progress on some of the referenced PRs. Is this change still relevant? If so, what are the next steps? |
|
Since this change doesn't appear to have much activity recently, I'm going to move it to the backlog for now. @bfjelds, if you find time to revisit this, please reach out. |
cottsay
added
backlog
and removed
in progress
|
There hasn't been activity here in quite a while, and this now needs a rebase, so I'm going to close this out. Feel free to reopen or open a new PR if you want to continue. Thanks for the contribution. |
5 participants
Most of these changes were made while trying to enable filters and laser_filters (using Node namespace, moving from boost to std, etc).
NO_ERROR is already defined for Windows, so I changed it here to NO_ERRORS.
I wasn't sure how best to handle time in ROS2, tried to get it right :).