suppress spam in canTransform

[grishalipenko]

suppress spam of "Warning: Invalid frame ..." if timeout > 0 and errstr != nullptr`

[grishalipenko]

resolve #501

[jacobperron]

I suggest we pass in a temporary string to these calls too, otherwise callers have no choice but to suffer the spam if they call lookupTransform:

geometry2/tf2_ros/src/buffer.cpp

Line 94 in ef2dd14

canTransform(target_frame, source_frame, lookup_time, timeout);

geometry2/tf2_ros/src/buffer.cpp

Line 117 in ef2dd14

canTransform(target_frame, target_time, source_frame, source_time, fixed_frame, timeout);

[gonzodepedro]

There are code style divergences:

--- src/buffer.cpp
+++ src/buffer.cpp.uncrustify
@@ -149,2 +149,3 @@
-    !canTransform(target_frame, source_frame, time,
-                  tf2::Duration(std::chrono::nanoseconds::zero()), errstr) &&
+    !canTransform(
+      target_frame, source_frame, time,
+      tf2::Duration(std::chrono::nanoseconds::zero()), errstr) &&
@@ -178,2 +179,3 @@
-    !canTransform(target_frame, target_time, source_frame, source_time, fixed_frame,
-                  tf2::Duration(std::chrono::nanoseconds::zero()), errstr) &&
+    !canTransform(
+      target_frame, target_time, source_frame, source_time, fixed_frame,
+      tf2::Duration(std::chrono::nanoseconds::zero()), errstr) &&

[jacobperron]

Replaced by #529