Merged
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Member
Author
|
clalancette
requested changes
Sep 15, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
A few minor comments to fix.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
clalancette
approved these changes
Sep 16, 2020
Member
Author
|
delete-merged-branch
bot
deleted the
ivanpauno/activate-usual-compiler-warnings-and-fix-errors-in-tf2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #270.
Decoupling the fixes in
tf2to see if I can find why windows is failing 😬