Conversation
|
CI:
|
clalancette
force-pushed
the
tf2_buffer_core_cleanup
branch
3 times, most recently
from
df0ba86 to
c8ff1f5
Compare
tf2/src/buffer_core.cpp
Outdated
| default: | ||
| CONSOLE_BRIDGE_logError("Unknown error code: %d", retval); | ||
| assert(0); | ||
| throw std::runtime_error("Unknown error code: " + std::to_string(static_cast<int>(retval))); |
There was a problem hiding this comment.
This is specifically an assert not an exception as it's not something that can or should be hit without a coding error and then can be compiled out for production. And isn't something that's recoverable so the developers shouldn't be trying to catch it.
When this was ported it used a ROS_ASSERT before. And the equivalent functionality was proposed to be ported here but that was stopped because it was a port and not a reimplementation: ros2/rcutils#112
There was a problem hiding this comment.
All right. I've put this back to an assert. I don't think it is in the purview of a library to assert, but I can live without it for now for the rest of the cleanups.
clalancette
force-pushed
the
tf2_buffer_core_cleanup
branch
from
c8ff1f5 to
847d768
Compare
This does a few things: 1. Removes commented out code. This code has been commented out for a decade, so I think it is safe to say nobody is using it. 2. Uses size_t everywhere we are calling vector.size() 3. Ensures all member variables are suffixed with _ 4. Removes asserts and replaces them with exceptions. 5. Gets rid of redundant branches for error cases and uses just one switch statement for all possible return values. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
tf2_buffer_core_cleanup
branch
from
847d768 to
593b9de
Compare
|
@ros-pull-request-builder retest this please |
|
CI:
|
2 participants
This does a few things:
out for a decade, so I think it is safe to say nobody is
using it.
uses just one switch statement for all possible return values.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org