Use const& signature for read-only sub callbacks#337
Merged
adityapande-1995 merged 1 commit intomasterfrom Feb 16, 2022
Merged
Conversation
The constant reference message signatures should be preferred over the shared pointer to constant message signatures for read-only subscriber callbacks, as discussed in ros2/rclcpp#1598. As such, it makes sense to migrate to said signatures in the examples. Signed-off-by: Abrar Rahman Protyasha <aprotyas@u.rochester.edu>
Member
Author
|
CI
|
wjwwood
approved these changes
Feb 16, 2022
Member
wjwwood
left a comment
wjwwood
left a comment
There was a problem hiding this comment.
lgtm
This isn't strictly required (there's no problem using ::ConstSharedPtr in this case), but I do agree that const & is easier to read and understand and also has no drawback as a recommendation. So 👍 from me.
adityapande-1995
approved these changes
Feb 16, 2022
delete-merged-branch
bot
deleted the
aprotyas/const_ref_sub_callbacks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constant reference message signatures should be preferred over the
shared pointer to constant message signatures for read-only subscriber
callbacks, as discussed in ros2/rclcpp#1598.
As such, it makes sense to migrate to said signatures in the examples.
Note that this should be backported to Galactic only.
Signed-off-by: Abrar Rahman Protyasha aprotyas@u.rochester.edu