Add design document for ROS 2 Access Control Policies #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrofa
reviewed
Jul 26, 2019
kyrofa
reviewed
Jul 26, 2019
|
If there is no more feedback, perhaps we could merge on this, that reflects the current state, so that we can open a new PR to extend the design to account for proposals on composing nodes and contexts. |
jacobperron
reviewed
Aug 26, 2019
jacobperron
reviewed
Aug 26, 2019
|
@jacobperron , thanks for the wording suggestions. They all looked fine to me. |
kyrofa
approved these changes
Aug 27, 2019
|
The change to the CSS is unrelated to the SROS article and I think would be best to pull out into a separate PR to review. |
Co-Authored-By: Kyle Fazzari <[email protected]>
Co-Authored-By: Daniel Wang <[email protected]>
Co-Authored-By: Jacob Perron <[email protected]>
ruffsl
force-pushed
the
ros2_access_control_policies
branch
from
90fd411
to
23726b4
Compare
I've rebased the PR and opened the syntax highlighting changes to its own PR: #253 |
jacobperron
approved these changes
Aug 27, 2019
|
Thanks for splitting out the PR. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently used for SROS 2.