Skip to content

Pin VS BuildTools to 16.5.5 in order to avoid broken VC++ download. #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brawner merged 2 commits into from
Jun 3, 2020
Merged

Pin VS BuildTools to 16.5.5 in order to avoid broken VC++ download. #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b3816
Pin VS BuildTools to 16.6
brawner Jun 3, 2020
7cd72eb
Adding comment
brawner Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion windows_docker_resources/Dockerfile.dashing
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ COPY rticonnextdds-src\rti_security_plugins-5.3.1-target-x64Win64VS2017.rtipkg C
RUN ""%ProgramFiles%\rti_connext_dds-5.3.1\bin\rtipkginstall.bat" C:\TEMP\connext\rti_security_plugins-5.3.1-target-x64Win64VS2017.rtipkg"

# Visual Studio Build Tools and .Net SDK`
ADD https://aka.ms/vs/16/release/vs_BuildTools.exe C:\TEMP\
# Pinning to 16.5.5 as building the netifaces wheel fails to find VC++
ADD https://download.visualstudio.microsoft.com/download/pr/68d6b204-9df0-4fcc-abcc-08ee0eff9cb2/17af83ed545d1287df7575786c326009e459708b60a6821d2a4f5606ef8efb9e/vs_BuildTools.exe C:\TEMP\
# ADD https://aka.ms/vs/16/release/vs_BuildTools.exe C:\TEMP\

# 3010 is an acceptable exit code (install was successful but restart required), but it will confuse docker.
# This installer invalidates docker image caches pretty regularly, so it's late in the order. See documentation for installer at:
Expand Down
4 changes: 3 additions & 1 deletion windows_docker_resources/Dockerfile.foxy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ COPY rticonnextdds-src\rti_security_plugins-5.3.1-target-x64Win64VS2017.rtipkg C
RUN ""%ProgramFiles%\rti_connext_dds-5.3.1\bin\rtipkginstall.bat" C:\TEMP\connext\rti_security_plugins-5.3.1-target-x64Win64VS2017.rtipkg"

# Visual Studio Build Tools and .Net SDK`
ADD https://aka.ms/vs/16/release/vs_BuildTools.exe C:\TEMP\
# Pinning to 16.5.5 as building the netifaces wheel fails to find VC++
ADD https://download.visualstudio.microsoft.com/download/pr/68d6b204-9df0-4fcc-abcc-08ee0eff9cb2/17af83ed545d1287df7575786c326009e459708b60a6821d2a4f5606ef8efb9e/vs_BuildTools.exe C:\TEMP\
# ADD https://aka.ms/vs/16/release/vs_BuildTools.exe C:\TEMP\

# 3010 is an acceptable exit code (install was successful but restart required), but it will confuse docker.
# This installer invalidates docker image caches pretty regularly, so it's late in the order. See documentation for installer at:
Expand Down