Pin VS BuildTools to 16.5.5 in order to avoid broken VC++ download.#462
Pin VS BuildTools to 16.5.5 in order to avoid broken VC++ download.#462
Conversation
cottsay
left a comment
cottsay
left a comment
There was a problem hiding this comment.
LGTM once CI passes. Hopefully we'll have time to dig into what is going wrong later this week.
|
Any comment to why this is done would be helpful in this ticket. |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/pin-vs-version
branch
from
8988418 to
d6b3816
Compare
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
Added a comment to the dockerfiles. And pinned to 16.5.5 instead. CI build underway I have to go walk my dog, so if this passes and people want to merge, or modify the PR and merge please feel free. |
nuclearsandwich
changed the title
I re-wrote the PR body and title with more context. |
|
I don’t think I configured the CI job correctly. It installed 16.6.1 instead of 16.5.5. I accidentally set ci_branch_to_test instead of CI_Scripts_branch
… On Jun 2, 2020, at 7:22 PM, Steven! Ragnarök ***@***.***> wrote:
Any comment to why this is done would be helpful in this ticket.
I re-wrote the PR body and title with more context.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
|
Thanks Scott!
… On Jun 2, 2020, at 8:01 PM, Scott K Logan ***@***.***> wrote:
I accidentally set ci_branch_to_test instead of ci_scripts_branch
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Ok passing build. Merging |
|
@brawner Please create a follow up ticket to unpin. |
|
@brawner Did you run a full CI build with this change? Could these new warnings be related to this change: https://ci.ros2.org/job/ci_windows/10912/msbuild/new/ |
Maybe the updated version of VS has something to do with why they're now being reported on the buildfarm, but those warnings are coming from ros2/rclcpp#1123. Seems like they should have been present all along, so it seems to me that this is an improvement. |
No, just up to rcpputils. It's odd that reverting to an older version of VS buildtools would have brought up more warnings. Hopefully there isn't a bloodbath tonight... |
I'd certainly rather we see some existing problems come to light than not get Windows builds at all :P |
|
Followup issue #463 |
4 participants
The daily Dockerfile invalidation updated VS BuildTools to 16.6 which is apparently missing the visual studio package download for Visual C++ (as reported here). The result is that the python wheel installation of netifaces fails although without a C++ compiler the rest of the build isn't likely to pass if we worked around that.
By pinning back to the earlier Build Tools version we keep the old package which is still available and thus can continue building. We should be able to lift this pin when an updated Build Tools is available which includes the missing VC++ package.
Signed-off-by: Stephen Brawner brawner@gmail.com