add source entry for new package conditional_substitution#40824
Closed
ottojo wants to merge 1 commit intoros:masterfrom
Closed
add source entry for new package conditional_substitution#40824ottojo wants to merge 1 commit intoros:masterfrom
ottojo wants to merge 1 commit intoros:masterfrom
Conversation
Contributor
New package review checklistYou can copy-paste the below into your review comment when reviewing a new package addition into rosdistro.
|
Contributor
Author
|
It does not differ at all from ros2/launch#734, which is why i opened ros2/launch#776 and converted this back to draft. I only opened this because i didn't know about the implementation in launch, which so far is only available in rolling i think, and which i only discovered just after opening this 🙃 |
Contributor
|
All right. In that case, I'm going to go ahead and close this since we can get the same functionality from that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Add This Package to be indexed in the rosdistro.
This package provides a single utility function for choosing substitutions in a launch file depending on a condition.
The source is here: https://github.com/ottojo/ros_conditional_substitution
Checks