Skip to content

add source entry for new package conditional_substitution#40824

Closed
ottojo wants to merge 1 commit intoros:masterfrom
ottojo:conditional_substitution
Closed

add source entry for new package conditional_substitution#40824
ottojo wants to merge 1 commit intoros:masterfrom
ottojo:conditional_substitution

Conversation

@ottojo
Copy link
Copy Markdown
Contributor

@ottojo ottojo commented Apr 24, 2024

Please Add This Package to be indexed in the rosdistro.

This package provides a single utility function for choosing substitutions in a launch file depending on a condition.

The source is here: https://github.com/ottojo/ros_conditional_substitution

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the iron Issue/PR is for the ROS 2 Iron distribution label Apr 24, 2024
@ottojo ottojo changed the title add source and doc repo entries for conditional_substitution add source entry for new package conditional_substitution Apr 24, 2024
@ottojo ottojo marked this pull request as draft April 25, 2024 20:14
@clalancette
Copy link
Copy Markdown
Contributor

New package review checklist

You can copy-paste the below into your review comment when reviewing a new package addition into rosdistro.

@ottojo
Copy link
Copy Markdown
Contributor Author

ottojo commented Apr 26, 2024

It does not differ at all from ros2/launch#734, which is why i opened ros2/launch#776 and converted this back to draft. I only opened this because i didn't know about the implementation in launch, which so far is only available in rolling i think, and which i only discovered just after opening this 🙃

@clalancette
Copy link
Copy Markdown
Contributor

All right. In that case, I'm going to go ahead and close this since we can get the same functionality from that PR.

@ottojo ottojo deleted the conditional_substitution branch April 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iron Issue/PR is for the ROS 2 Iron distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants