Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any Python files in
omniorb
. Isomniidl
enough here?https://packages.debian.org/sid/amd64/omniorb/filelist
https://packages.debian.org/sid/amd64/omniidl/filelist
It looks like
python-omniorb
was a key in older versions of debian: https://tracker.debian.org/pkg/python-omniorbI'm not really seeing the key in fedora either: https://src.fedoraproject.org/rpms/omniORB/blob/rawhide/f/omniORB.spec
Maybe it's time we drop this key in favor of
rosdistro/rosdep/base.yaml
Line 6857 in 10c5cc8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the link from @sloretz , it looks like this key was dropped from Debian in 2018. So I think we can just remove this key completely.