Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-omniorb is not available on debian, use omniorb, see https://packages.debian.org/search?suite=all&section=all&arch=any&searchon=names&keywords=omniidl #39111

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rosdep/python.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2562,7 +2562,7 @@ python-objectpath-pip:
packages: [objectpath]
python-omniorb:
arch: [omniorbpy]
debian: [python-omniorb, python-omniorb-omg, omniidl-python]
debian: [omniorb, omniidl]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any Python files in omniorb. Is omniidl enough here?

https://packages.debian.org/sid/amd64/omniorb/filelist
https://packages.debian.org/sid/amd64/omniidl/filelist

It looks like python-omniorb was a key in older versions of debian: https://tracker.debian.org/pkg/python-omniorb

I'm not really seeing the key in fedora either: https://src.fedoraproject.org/rpms/omniORB/blob/rawhide/f/omniORB.spec

Maybe it's time we drop this key in favor of

omniorb:
?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the link from @sloretz , it looks like this key was dropped from Debian in 2018. So I think we can just remove this key completely.

fedora: [python-omniORB, omniORB-devel]
gentoo: ['net-misc/omniORB[python]']
ubuntu:
Expand Down
Loading