Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-omniorb is not available on debian, use omniorb, see https://packages.debian.org/search?suite=all&section=all&arch=any&searchon=names&keywords=omniidl #39111

Closed
wants to merge 1 commit into from

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Nov 30, 2023

Please add the following dependency to the rosdep database.

Package name:

python-omniorb

Package Upstream Source:

[python-omniorb, python-omniorb-omg, omniidl-python] is not avilable on debian.

https://packages.debian.org/search?suite=all&section=all&arch=any&searchon=names&keywords=omniidl

This fix should resolve build failure on https://build.ros.org/job/Nbin_db_dB64__openhrp3__debian_buster_amd64__binary/289/console ()

@k-okada k-okada requested a review from a team as a code owner November 30, 2023 14:43
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Nov 30, 2023
@@ -2562,7 +2562,7 @@ python-objectpath-pip:
packages: [objectpath]
python-omniorb:
arch: [omniorbpy]
debian: [python-omniorb, python-omniorb-omg, omniidl-python]
debian: [omniorb, omniidl]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any Python files in omniorb. Is omniidl enough here?

https://packages.debian.org/sid/amd64/omniorb/filelist
https://packages.debian.org/sid/amd64/omniidl/filelist

It looks like python-omniorb was a key in older versions of debian: https://tracker.debian.org/pkg/python-omniorb

I'm not really seeing the key in fedora either: https://src.fedoraproject.org/rpms/omniORB/blob/rawhide/f/omniORB.spec

Maybe it's time we drop this key in favor of

omniorb:
?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the link from @sloretz , it looks like this key was dropped from Debian in 2018. So I think we can just remove this key completely.

@clalancette
Copy link
Contributor

Given the latest comments, I'm going to close this out. I'll do a follow-up to remove this key completely, since there are no active distributions that have it available as far as we can tell.

@clalancette clalancette closed this Dec 8, 2023
@k-okada k-okada deleted the fix_for_buster branch December 13, 2023 08:16
@k-okada
Copy link
Contributor Author

k-okada commented Dec 15, 2023

thank you for comments, I'll use omniidl omniorb rosdep keys insted.

tork-a/openhrp3-release@507893d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants