Conversation
tfoote
left a comment
There was a problem hiding this comment.
We shouldn't add pip rules that will conflict/override existing debian rules. If any package in the workspace or system depends on the pip rule it will override the version that is available on the system and potentially break anyone using the apt based key. If we want to add this key it should only be valid for platforms where there is no resolution for the conflicting apt/debian based key.
|
In addition to @tfoote's points above about not mixing keys. Pip packages can't be used to resolve dependencies for packages released via bloom. Based on the comment here: https://github.com/ipa320/cob_command_tools/issues/289#issuecomment-766696766 it seems like this dependency has been worked around. If that's the case @fmessmer can we close this PR as unnecessary? Thanks for iterating on the solution with us! |
|
yes, I guess I won't need this anymore once the following PRs are merged: |
|
ros-infrastructure/ros_buildfarm_config#196 is merged and the release does not issue any warnings anymore...so I guess this key is not needed anymore.... |
this adds a rosdep key for the pip version of
mechanize(https://pypi.org/project/mechanize/)officital
python-mechanize/python3-mechanizeare already available, butpython3-mechanizeis not available fordebian:busterand thus results in problematic release of e.g. https://github.com/ipa320/cob_command_tools(read more about it in https://github.com/ipa320/cob_command_tools/issues/289