Skip to content

add python-mechanize-pip#28067

Closed
fmessmer wants to merge 1 commit intoros:masterfrom
fmessmer:add_python-mechanize-pip
Closed

add python-mechanize-pip#28067
fmessmer wants to merge 1 commit intoros:masterfrom
fmessmer:add_python-mechanize-pip

Conversation

@fmessmer
Copy link
Copy Markdown
Contributor

this adds a rosdep key for the pip version of mechanize (https://pypi.org/project/mechanize/)

officital python-mechanize/python3-mechanize are already available, but python3-mechanize is not available for debian:buster and thus results in problematic release of e.g. https://github.com/ipa320/cob_command_tools
(read more about it in https://github.com/ipa320/cob_command_tools/issues/289

Copy link
Copy Markdown
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't add pip rules that will conflict/override existing debian rules. If any package in the workspace or system depends on the pip rule it will override the version that is available on the system and potentially break anyone using the apt based key. If we want to add this key it should only be valid for platforms where there is no resolution for the conflicting apt/debian based key.

@ivanpauno ivanpauno added the rosdep Issue/PR is for a rosdep key label Jan 25, 2021
@nuclearsandwich
Copy link
Copy Markdown
Member

In addition to @tfoote's points above about not mixing keys. Pip packages can't be used to resolve dependencies for packages released via bloom. Based on the comment here: https://github.com/ipa320/cob_command_tools/issues/289#issuecomment-766696766 it seems like this dependency has been worked around. If that's the case @fmessmer can we close this PR as unnecessary?

Thanks for iterating on the solution with us!

@fmessmer
Copy link
Copy Markdown
Contributor Author

@fmessmer
Copy link
Copy Markdown
Contributor Author

ros-infrastructure/ros_buildfarm_config#196 is merged and the release does not issue any warnings anymore...so I guess this key is not needed anymore....

@fmessmer fmessmer closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rosdep Issue/PR is for a rosdep key

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants