Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default duration in TimeCache #315

Closed
csukuangfj opened this issue Aug 14, 2018 · 1 comment
Closed

default duration in TimeCache #315

csukuangfj opened this issue Aug 14, 2018 · 1 comment

Comments

@csukuangfj
Copy link
Contributor

geometry2/tf2/include/tf2/time_cache.h

Lines 99 to 101 in 7ea64d2

static const int64_t DEFAULT_MAX_STORAGE_TIME = 1ULL * 1000000000LL; //!< default value of 10 seconds storage
TimeCache(ros::Duration max_storage_time = ros::Duration().fromNSec(DEFAULT_MAX_STORAGE_TIME));

The comment default value of 10 seconds storage says it saves a duration of 10 seconds, but
the value 1ULL * 1000000000LL is 1 second, i.e., there are only 9 zeros, not 10 zeros.
csukuangfj added a commit to open-cv/geometry2 that referenced this issue Aug 14, 2018
@csukuangfj
fix issue ros#315
123dd50
@csukuangfj csukuangfj mentioned this issue Aug 14, 2018
Merged
tfoote pushed a commit that referenced this issue Aug 14, 2018
@csukuangfj @tfoote
fix issue #315
b516a8a
tfoote pushed a commit that referenced this issue Oct 19, 2018
@csukuangfj @tfoote
fix issue #315
3f79d15
@tfoote
Copy link
Member

tfoote commented Oct 19, 2018

Fixed in #317

@tfoote tfoote closed this as completed Oct 19, 2018
@tfoote tfoote mentioned this issue Oct 19, 2018
Merged
tfoote pushed a commit that referenced this issue Oct 23, 2018
@csukuangfj @tfoote
fix issue #315
210c0d6
seanyen pushed a commit to ms-iot/geometry2 that referenced this issue Mar 22, 2021
@surfertas @clalancette
Add type hints to tf2_ros_py code(ros#275) (ros#315)
d7276d5 
* adding typehints to tf2_ros_py code

Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfoote @csukuangfj