Install headers to include/${PROJECT_NAME} and export modern CMake targets#63
Merged
sloretz merged 1 commit intoMar 30, 2022
Merged
Conversation
Contributor
Author
|
@mabelzhang got time to review this one? I don't have a good way to test this one |
Contributor
Author
|
@ros-pull-request-builder retest this please |
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
force-pushed
the
sloretz__rqt_image_view__include_projectname
branch
from
045be14 to
cfa24af
Compare
Contributor
Author
|
PR job is green, and this package is blocked from ci.ros2.org, so merging 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1150 - this installs headers to a unique include directory to prevent include directory search order issues when overriding packages from a merged workspace.
I don't have a good way to run CI for this package other than the PR job since vision_opencv is blacklisted from ci.ros2.org