bump colcon to latest package versions#69
Merged
thomas-moulard merged 2 commits intoros-tooling:masterfrom Apr 2, 2020
Merged
Conversation
|
If the tests pass, then they should work. This PR actually brings up a good point to probably have some sort of intergration test workflow with |
|
I've opened #70 to track the above comment |
emersonknapp
approved these changes
Mar 23, 2020
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
57a3cbd to
81ab4b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback from ros-tooling/action-ros-ci#109 (comment)
The versions picked are the ones returned by
colcon version-checkon an up to date system.Details
AFAICT these versions are compatible, is there any specific test to actually confirm it ?