Skip to content

bump colcon to latest package versions#69

Merged
thomas-moulard merged 2 commits intoros-tooling:masterfrom
mikaelarguedas:bump-colcon
Apr 2, 2020
Merged

bump colcon to latest package versions#69
thomas-moulard merged 2 commits intoros-tooling:masterfrom
mikaelarguedas:bump-colcon

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Contributor

Based on feedback from ros-tooling/action-ros-ci#109 (comment)

The versions picked are the ones returned by colcon version-check on an up to date system.

Details
colcon-argcomplete 0.3.3: up-to-date
colcon-bash 0.4.2: up-to-date
colcon-cd 0.1.1: up-to-date
colcon-cmake 0.2.19: up-to-date
colcon-core 0.5.5: up-to-date
colcon-defaults 0.2.4: up-to-date
colcon-devtools 0.2.2: up-to-date
colcon-lcov-result 0.3.0: up-to-date
colcon-library-path 0.2.1: up-to-date
colcon-metadata 0.2.4: up-to-date
colcon-mixin 0.1.6: up-to-date
colcon-notification 0.2.12: up-to-date
colcon-output 0.2.8: up-to-date
colcon-package-information 0.3.2: up-to-date
colcon-package-selection 0.2.5: up-to-date
colcon-parallel-executor 0.2.4: up-to-date
colcon-pkg-config 0.1.0: up-to-date
colcon-powershell 0.3.6: up-to-date
colcon-python-setup-py 0.2.5: up-to-date
colcon-recursive-crawl 0.2.1: up-to-date
colcon-ros 0.3.17: up-to-date
colcon-test-result 0.3.8: up-to-date
colcon-zsh 0.4.0: up-to-date

AFAICT these versions are compatible, is there any specific test to actually confirm it ?

@piraka9011
Copy link
Copy Markdown

If the tests pass, then they should work. This PR actually brings up a good point to probably have some sort of intergration test workflow with action-ros-ci to verify that these two work well in tandem.
I'd confirm just by specifying the version of ros-tooling/setup-ros in the workflow of the PR you opened.
So change .github/workflows/test.yml's workflow to use mikaelarguedas/setup-ros@bump-colcon instead of ros-tooling/setup-ros@0.0.15

@piraka9011
Copy link
Copy Markdown

I've opened #70 to track the above comment

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@thomas-moulard thomas-moulard merged commit 83305be into ros-tooling:master Apr 2, 2020
@mikaelarguedas mikaelarguedas deleted the bump-colcon branch April 2, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants