use colcon option for pytest coverage instead of custom pytest-cov options#109
Merged
piraka9011 merged 8 commits intoros-tooling:masterfrom Jul 10, 2020
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in the following pytest-args:
--cov=<PATH/TO/ROS/PACKAGE>--cov-report=html:<PATH/TO/PKG/BUILD/DIR>/coverage.html--cov-report=xml:<PATH/TO/PKG/BUILD/DIR>/coverage.xml--cov-branchhttps://github.com/colcon/colcon-core/blob/af7fa089962a9e9a35926734e17b00cfb4c780a6/colcon_core/task/python/test/pytest.py#L85-L100
The main advantage is that it prevents action-ros-ci to overwrite the output location of the coverage.xml (colcon places it in the build directory of the package) and to have branch coverage in the report.
Note: this needs colcon-core 0.5.1 so doesnt work as is as setup-ros pins colcon version to 0.4.3.
Should I open a separate issue to request a version bump of colcon packages in setup-ros?