Use Boost::pythonXY target #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <[email protected]>
mjcarroll
approved these changes
Jan 24, 2022
This was referenced Jan 24, 2022
ijnek
added a commit
that referenced
this pull request
Sep 17, 2022
This reverts commit e1df7ee. Signed-off-by: Kenji Brameld <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Sep 17, 2022
This reverts commit e1df7ee. Signed-off-by: Kenji Brameld <[email protected]> (cherry picked from commit 7a9b580)
Ace314159
added a commit
to Ace314159/vision_opencv
that referenced
this pull request
Sep 18, 2022
This reverts commit 7a9b580.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR links against the
Boost::pythonXYtarget since that's the portable CMake target naming.This should fix the build failure on RHEL8 https://build.ros2.org/view/Rbin_rhel_el864/job/Rbin_rhel_el864__cv_bridge__rhel_8_x86_64__binary/56/consoleText
#390 and #344 are doing very similar things, and I think this PR replaces them. I used feedback from both of those in this one. (@flynneva and @floesche FYI)