Fix Boost Python 2/3 for old and new Boost. #274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolausDemmel
approved these changes
Mar 27, 2019
NikolausDemmel
left a comment
NikolausDemmel
left a comment
There was a problem hiding this comment.
Thanks Mike. I don't have time to test, but from quick review it looks reasonable. For macos, brewed boost is now > 1.67 (on any version of macos), and that case looks identical to #239 (except for the logic computing the major and minor version digits), so I assume it would work the same.
mikepurvis
commented
Mar 28, 2019
Merged
Author
|
Xenial and Python 2 are long dead to us; this is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler version of #239.
I have validated this with Python 2 and Python 3 on Xenial, so I know it works in that scenario (where the proposed solution from #239 does not work for Python 3). And I believe it should work for Boost 1.67+ as well, based on the original fix.
@meyerj @NikolausDemmel @vrabaud