Skip to content

Add python3-numpy as build and execution dependency#243

Merged
gaoethan merged 2 commits intoros-perception:ros2from
gaoethan:vision_opencv_dev
Aug 17, 2018
Merged

Add python3-numpy as build and execution dependency#243
gaoethan merged 2 commits intoros-perception:ros2from
gaoethan:vision_opencv_dev

Conversation

@gaoethan
Copy link
Copy Markdown
Contributor

numpy is necessary not only for test but also a dependency for building and runtime execution.
More details at ros2/rosdistro#260

@mikaelarguedas
Copy link
Copy Markdown
Contributor

python3-numpy can now be removed as a test_depend.
test_depend is only necessary for additional dependencies needed uniquely for testing. As numpy is now listed as a build/exec dependency, the test_depend is not necessary anymore.

Copy link
Copy Markdown
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gaoethan gaoethan merged commit 96beefa into ros-perception:ros2 Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants