Skip to content

Revert the license to keep its original#220

Merged
gaoethan merged 1 commit intoros-perception:ros2from
gaoethan:vision_opencv_dev
Jun 5, 2018
Merged

Revert the license to keep its original#220
gaoethan merged 1 commit intoros-perception:ros2from
gaoethan:vision_opencv_dev

Conversation

@gaoethan
Copy link
Copy Markdown
Contributor

@gaoethan gaoethan commented Jun 1, 2018

Revert the license which was aligned to Apache 2.0 in #216 to keep its original
Signed-off-by: Ethan Gao ethan.gao@linux.intel.com

@gaoethan gaoethan requested a review from mikaelarguedas June 1, 2018 02:54
@gaoethan
Copy link
Copy Markdown
Contributor Author

gaoethan commented Jun 1, 2018

@mikaelarguedas I've already reverted all the license to its original, please kindly help give a simple review and let me if any problem. thanks !

Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
@mikaelarguedas
Copy link
Copy Markdown
Contributor

This looks good 👍
Thanks @gaoethan for iterating on this.

Note: In general we add new copyright notice when a significant feature / behavioral change is being made. By the look of it, most of the files changes are about style (for example rgb_colors.h) and thus would not qualify to add a new copyright holder.
We can keep it as is for now, but we should keep it in mind in the future.

Piggy-backing on the remark about style changes, please consider (when you have a chance) addressing the remark about keeping the diff minimal with the ROS1 version, by either submitting style changes upstream or not applying them to the ros2 branch

Copy link
Copy Markdown
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaoethan gaoethan merged commit 30c2b04 into ros-perception:ros2 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants