Skip to content

[ros2] Fix RCLCPP_* logs, a string literal must be the first argument #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjcarroll merged 2 commits into from
Jul 7, 2021
Merged

[ros2] Fix RCLCPP_* logs, a string literal must be the first argument #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70236de
Fix RCLCPP_* logs, a literal string must be the first argument
ivanpauno Jun 17, 2021
038a6dc
fix
ivanpauno Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compressed_image_transport/src/compressed_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ void CompressedPublisher::advertiseImpl(
}
else
{
RCLCPP_WARN(logger_, format_param_name + " was previously delared");
RCLCPP_WARN(logger_, "%s was previously declared", format_param_name.c_str());
}

std::string png_level_param_name = param_base_name + ".png_level";
Expand All @@ -101,7 +101,7 @@ void CompressedPublisher::advertiseImpl(
}
else
{
RCLCPP_WARN(logger_, png_level_param_name + " was previously delared");
RCLCPP_WARN(logger_, "%s was previously delared", png_level_param_name.c_str());
}

std::string jpeg_quality_param_name = param_base_name + ".jpeg_quality";
Expand All @@ -121,7 +121,7 @@ void CompressedPublisher::advertiseImpl(
}
else
{
RCLCPP_WARN(logger_, jpeg_quality_param_name + " was previously delared");
RCLCPP_WARN(logger_, "%s was previously delared", jpeg_quality_param_name.c_str());
}
}

Expand Down