Fix deprecation warning calling declare_parameter#642
Merged
JWhitleyWork merged 1 commit intoMar 18, 2021
Conversation
As of ros2/rclcpp#1522, we must also declare the type of the parameter. We can do this implicitly by providing a default value. Prior to this change, distance_ was being default-initialized to 0.0 anyways. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
JWhitleyWork
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of ros2/rclcpp#1522 (upcoming in Galactic), we must also declare the type of the parameter.
We can do this implicitly by providing a default value.
Prior to this change, distance_ was being default-initialized to 0.0 anyways.