Converging image_view node and nodelet#479
Merged
JWhitleyWork merged 1 commit intomelodicfrom Nov 25, 2019
Merged
Conversation
SteveMacenski
approved these changes
Nov 25, 2019
708yamaguchi
added a commit
to 708yamaguchi/image_pipeline
that referenced
this pull request
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow,
image_view.cpphad become its own stand-alone nodelet, completely separate from the nodelet. This brings them back together by removing the stand-alone node and replacing it with just a wrapper node around the nodelet.