Conversation
Codecov Report❌ Patch coverage is
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
left a comment
There was a problem hiding this comment.
I don't really understand the BT node/XML & action definitions.
For the actions, why not use the vision_msgs labels and standard sensor_msgs/Image? Why wouldn't this server just be doing segmentation over images coming in from the sensor live as a feed?
I guess I understand the BT node if you plan to only ask it to get you data in a snapshot. You may instead just want to have a simpler implementation that serves the last published semantic mask instead so it can live stream.
This PR doesn't really contain any "meat" from the server though to review, which is the main important element I think
To Do:
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.