Skip to content

Add LatchedPublisher QoS for dock and staging pose.#6038

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
kiwicampus:port/qos_docking_topics
Mar 18, 2026
Merged

Add LatchedPublisher QoS for dock and staging pose.#6038
SteveMacenski merged 1 commit intoros-navigation:mainfrom
kiwicampus:port/qos_docking_topics

Conversation

@Sunart24
Copy link
Copy Markdown
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

  • Change QoS to transient local allow watch it after the dock goal is sent if not subscribed

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...cking/opennav_docking/src/simple_charging_dock.cpp 96.11% <100.00%> (+0.05%) ⬆️
...g/opennav_docking/src/simple_non_charging_dock.cpp 95.81% <100.00%> (+0.06%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented Mar 17, 2026

This would be a breaking behavioral change that could compatibility issues, so can I suggest instead you use the fact that allow_parameter_qos_overrides is true so you can in your YAML file set these subscriptions QoS yourself?

Ex.

/fully/qualified/topic/name/here:
  publisher: # or 'subscription'
    reliability: reliable # Options: reliable, best_effort
    history: keep_last # Options: keep_last, keep_all
    depth: 100 # History depth, use 'depth' instead of 'history_depth'
    durability: volatile # Options: volatile, transient_local
    # other policies like liveliness, deadline, etc. can also be set

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually sorry, I'm mistaken, there is no compatibility issue concern.

@Sunart24 can you sign off on DCO though? Then I can merge

Signed-off-by: Sebastian Solarte <johan.solarte@kiwibot.com>
@Sunart24 Sunart24 force-pushed the port/qos_docking_topics branch from fbd9670 to fb68338 Compare March 17, 2026 22:41
@Sunart24
Copy link
Copy Markdown
Contributor Author

Done @SteveMacenski , thank you!

@SteveMacenski SteveMacenski merged commit c965a79 into ros-navigation:main Mar 18, 2026
16 checks passed
avanmalleghem pushed a commit to avanmalleghem/navigation2 that referenced this pull request Apr 6, 2026
)

Signed-off-by: Sebastian Solarte <johan.solarte@kiwibot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants