Skip to content

Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta_star#5964

Merged
SteveMacenski merged 9 commits intoros-navigation:mainfrom
mini-1235:feat/dynamic_params-4
Feb 20, 2026
Merged

Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta_star#5964
SteveMacenski merged 9 commits intoros-navigation:mainfrom
mini-1235:feat/dynamic_params-4

Conversation

@mini-1235
Copy link
Collaborator


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4907
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

…ller and theta star planner

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 98.23789% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...av2_docking/opennav_docking/src/docking_server.cpp 95.12% 2 Missing ⚠️
nav2_theta_star_planner/src/parameter_handler.cpp 96.55% 2 Missing ⚠️
Files with missing lines Coverage Δ
...docking/include/opennav_docking/docking_server.hpp 100.00% <ø> (ø)
nav2_docking/opennav_docking/src/controller.cpp 100.00% <100.00%> (ø)
nav2_docking/opennav_docking/src/dock_database.cpp 100.00% <100.00%> (ø)
..._docking/opennav_docking/src/parameter_handler.cpp 100.00% <100.00%> (ø)
.../nav2_mppi_controller/tools/parameters_handler.hpp 95.45% <100.00%> (-0.11%) ⬇️
nav2_mppi_controller/src/critics/cost_critic.cpp 84.21% <ø> (ø)
nav2_mppi_controller/src/parameters_handler.cpp 100.00% <100.00%> (ø)
...ner/include/nav2_theta_star_planner/theta_star.hpp 96.66% <100.00%> (+0.11%) ⬆️
nav2_theta_star_planner/src/theta_star.cpp 96.52% <100.00%> (-1.44%) ⬇️
nav2_theta_star_planner/src/theta_star_planner.cpp 91.66% <100.00%> (-0.96%) ⬇️
... and 2 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mini-1235 mini-1235 marked this pull request as ready for review February 18, 2026 13:03
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPPI's my only question

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
@SteveMacenski SteveMacenski merged commit e992937 into ros-navigation:main Feb 20, 2026
17 checks passed
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 21, 2026
…ller and theta_star (ros-navigation#5964)

* Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta star planner

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add code coverage

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* retrigger ci due to timeout

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Apply suggestions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 21, 2026
…ller and theta_star (ros-navigation#5964)

* Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta star planner

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add code coverage

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* retrigger ci due to timeout

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Apply suggestions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 21, 2026
…ller and theta_star (ros-navigation#5964)

* Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta star planner

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add code coverage

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* retrigger ci due to timeout

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Apply suggestions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 22, 2026
…ller and theta_star (ros-navigation#5964)

* Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta star planner

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add code coverage

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* retrigger ci due to timeout

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Apply suggestions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 22, 2026
…ller and theta_star (ros-navigation#5964)

* Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta star planner

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add code coverage

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* retrigger ci due to timeout

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Apply suggestions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 22, 2026
…ller and theta_star (ros-navigation#5964)

* Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta star planner

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add code coverage

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* retrigger ci due to timeout

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Apply suggestions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
EricoMeger pushed a commit to EricoMeger/navigation2 that referenced this pull request Feb 22, 2026
…ller and theta_star (ros-navigation#5964)

* Redesign dynamic parameters patterns for opennav_docking, mppi_controller and theta star planner

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add code coverage

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* retrigger ci due to timeout

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Apply suggestions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

* Retrigger CI

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants