Changing BT loading warning to be more clear by SteveMacenski · Pull Request #5938 · ros-navigation/navigation2

SteveMacenski · 2026-02-04T18:00:33Z

Per #5924

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

Comment out the ros2/rviz repository entry in underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

mergify · 2026-02-04T19:09:28Z

This pull request is in conflict. Could you fix it @SteveMacenski?

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

codecov · 2026-02-04T19:58:10Z

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...clude/nav2_behavior_tree/bt_action_server_impl.hpp	20.00%	4 Missing ⚠️

Files with missing lines	Coverage Δ
...clude/nav2_behavior_tree/bt_action_server_impl.hpp	`87.68% <20.00%> (-1.26%)`	⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…5938)" This reverts commit 517ebf4.

…5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Revert "Changing BT loading warning to be more clear (#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert "Bt warning fix (#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert unrelated changes Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Second prototype Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Only require main id when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test to cover corner case Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>

…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert unrelated changes Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Second prototype Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Only require main id when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test to cover corner case Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Signed-off-by: panav <panav@10xconstruction.com>

* Changing BT loading warning to be more clear Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Comment out ros2/rviz repository Comment out the ros2/rviz repository entry in underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert unrelated changes Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Second prototype Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Only require main id when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test to cover corner case Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Signed-off-by: panav <panav@10xconstruction.com>

…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert unrelated changes Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Second prototype Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Only require main id when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test to cover corner case Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>

…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert unrelated changes Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Second prototype Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Only require main id when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test to cover corner case Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Signed-off-by: panav <panav@10xconstruction.com>

…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert unrelated changes Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Second prototype Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Only require main id when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test to cover corner case Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Signed-off-by: panav <panav@10xconstruction.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com>

…#5950) * Revert "Changing BT loading warning to be more clear (ros-navigation#5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert "Bt warning fix (ros-navigation#5594)" This reverts commit 00dfd67. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix subtree parsing error when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Revert unrelated changes Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Second prototype Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Apply suggestions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Only require main id when using filepath Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix comment formatting in behavior_tree_engine.cpp Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Require main_tree_to_execute to be set if multiple BehaviorTree tags present Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test to cover corner case Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>

Changing BT loading warning to be more clear

236d253

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

SteveMacenski linked an issue Feb 4, 2026 that may be closed by this pull request

Confusing warning error for duplicate ID BTs #5924

Closed

SteveMacenski mentioned this pull request Feb 4, 2026

Confusing warning error for duplicate ID BTs #5924

Closed

Comment out ros2/rviz repository

573501e

Comment out the ros2/rviz repository entry in underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

Merge branch 'main' into change_warning_log

81004f2

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

SteveMacenski merged commit 517ebf4 into main Feb 4, 2026
15 of 16 checks passed

mergify bot deleted the change_warning_log branch February 4, 2026 20:01

mini-1235 added a commit to mini-1235/navigation2 that referenced this pull request Feb 11, 2026

Revert "Changing BT loading warning to be more clear (ros-navigation#…

06eb89a

…5938)" This reverts commit 517ebf4.

mini-1235 added a commit to mini-1235/navigation2 that referenced this pull request Feb 11, 2026

Revert "Changing BT loading warning to be more clear (ros-navigation#…

95dc177

…5938)" This reverts commit 517ebf4. Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

mini-1235 mentioned this pull request Feb 11, 2026

Fix error parsing subtree when loading from file path #5950

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing BT loading warning to be more clear#5938

Changing BT loading warning to be more clear#5938
SteveMacenski merged 3 commits intomainfrom
change_warning_log

SteveMacenski commented Feb 4, 2026

Uh oh!

mergify bot commented Feb 4, 2026

Uh oh!

codecov bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

SteveMacenski commented Feb 4, 2026

Uh oh!

mergify bot commented Feb 4, 2026

Uh oh!

codecov bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov bot commented Feb 4, 2026 •

edited

Loading