Skip to content

Add cancel timeout when cancelling actions (backport Jazzy)#5903

Merged
SteveMacenski merged 3 commits intoros-navigation:jazzyfrom
mini-1235:jazzy-patch-1
Jan 28, 2026
Merged

Add cancel timeout when cancelling actions (backport Jazzy)#5903
SteveMacenski merged 3 commits intoros-navigation:jazzyfrom
mini-1235:jazzy-patch-1

Conversation

@mini-1235
Copy link
Collaborator


Basic Info

Info Please fill out this column
Ticket(s) this addresses backport #5895
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

@mini-1235, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...tree/include/nav2_behavior_tree/bt_action_node.hpp 86.15% <100.00%> (+0.10%) ⬆️
...ee/include/nav2_behavior_tree/bt_action_server.hpp 83.33% <ø> (ø)
...clude/nav2_behavior_tree/bt_action_server_impl.hpp 88.60% <100.00%> (+1.02%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@SteveMacenski SteveMacenski merged commit e70bedb into ros-navigation:jazzy Jan 28, 2026
11 checks passed
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Mar 2, 2026
…gation#5903)

* Add cancel timeout when cancelling actions (backport Jazzy)

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Declare parameter

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Update cancel timeout

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants