Skip to content

Added test for timeout#5880

Closed
delihus wants to merge 2 commits intoros-navigation:jazzyfrom
delihus:jazzy-robot-utils-timeout-test
Closed

Added test for timeout#5880
delihus wants to merge 2 commits intoros-navigation:jazzyfrom
delihus:jazzy-robot-utils-timeout-test

Conversation

@delihus
Copy link
Copy Markdown
Contributor

@delihus delihus commented Jan 16, 2026

The getCurrentPose does not consider the times. What is a transform_timeout parameter?


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

  • added timeout test what should fail but it does not.

Description of documentation updates required from your changes

  • the documentation says that the getCurrentPose has its timeout but the timeout is ignore.

Description of how this change was tested

  • I wrote the test and it fails.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 16, 2026

@delihus, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
@mini-1235
Copy link
Copy Markdown
Collaborator

@delihus can you explain what this PR is trying to fix?

@delihus
Copy link
Copy Markdown
Contributor Author

delihus commented Jan 16, 2026

Actually, the changes provide the error that the function getCurrentPose does not respect provided timeout. The tests fail.

So the question for you is what is the transform_timeout argument. If it is the duration timeout between now() and last received timeout, it seems to not work properlly. I can add the timeout checking, but I need to understand this parameter. :D

@mini-1235
Copy link
Copy Markdown
Collaborator

The transform_timeout is used in the following code:

tf_buffer.transform(
      input_pose, target_frame,
      tf2::durationFromSec(transform_timeout));

You might want to take a look at https://github.com/ros2/geometry2/blob/13184de30f971a02b6e747e4ff2dacaf5f41c29a/tf2_ros/include/tf2_ros/buffer_interface.hpp#L229 to understand its usage.

Since this is a question related to geometry2, I am going to close this

@mini-1235 mini-1235 closed this Jan 16, 2026
@delihus
Copy link
Copy Markdown
Contributor Author

delihus commented Jan 16, 2026

Now I understand. Then the documentation is misleading. I will copy the parameter description from geometry2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants