Skip to content

Add symmetric goal for goal checker and mppi goal angle critic (backport jazzy)#5848

Merged
SteveMacenski merged 1 commit intoros-navigation:jazzyfrom
mini-1235:jazzy
Jan 7, 2026
Merged

Add symmetric goal for goal checker and mppi goal angle critic (backport jazzy)#5848
SteveMacenski merged 1 commit intoros-navigation:jazzyfrom
mini-1235:jazzy

Conversation

@mini-1235
Copy link
Collaborator


Basic Info

Info Please fill out this column
Ticket(s) this addresses backport of #5833
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

…avigation#5833)

* Add symmetric goal for goal checker and mppi goal angle critic

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: Sandeep Dutta <quark01@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Update nav2_mppi_controller/README.md

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Co-authored-by: Sandeep Dutta <quark01@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Jan 7, 2026

@mini-1235, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
..._mppi_controller/src/critics/goal_angle_critic.cpp 87.50% 1 Missing ⚠️
Files with missing lines Coverage Δ
nav2_controller/plugins/simple_goal_checker.cpp 100.00% <100.00%> (ø)
...nav2_mppi_controller/critics/goal_angle_critic.hpp 100.00% <ø> (ø)
..._mppi_controller/src/critics/goal_angle_critic.cpp 91.30% <87.50%> (+7.09%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit da21f48 into ros-navigation:jazzy Jan 7, 2026
11 checks passed
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Mar 2, 2026
…avigation#5833) (ros-navigation#5848)

* Add symmetric goal for goal checker and mppi goal angle critic




* Lint



* Update nav2_mppi_controller/README.md




---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Co-authored-by: Sandeep Dutta <quark01@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants