Updated ament_index_cpp API

[ahcorde]

Related with ament/ament_index#104

[mini-1235]

@ahcorde Since ament/ament_index#104 is not (and cannot be) backported to Jazzy or Kilted, I think we'll need to add a version check here in order to keep main buildable against Jazzy and Kilted.

[SteveMacenski]

This doesn't compile yet - but I expect that's just because the binaries haven't synced yet for the changes. Thanks for the proactive PR.

@mini-1235 has a point on the cross compatibility with jazzy/kilted if this isn't being backported there (which I assume it isn't). An easy fix for that would be to create a nav2_ros_common::get_package_share_directory() API which is globally used. Then we have the ifdef on the versions in a single place.

Here seems pretty reasonable if you didn't want to put it into a new file itself. I don't have a strong opinion.

[mini-1235]

@ahcorde, any updates on this PR? I believe the rolling sync is happening soon? 😄

[mini-1235]

@ahcorde any updates? We'd like to get this merged in the next few days

[SteveMacenski]

I retriggered CI, still failing but not sure if the sync has trickled in

[mini-1235]

@ahcorde since the sync has completed, I will take over to unblock other PRs. Thanks for your efforts here!