Expose CostmapSubscriber's callback group#5810
Merged
tonynajjar merged 2 commits intoros-navigation:mainfrom Dec 29, 2025
Merged
Expose CostmapSubscriber's callback group#5810tonynajjar merged 2 commits intoros-navigation:mainfrom
tonynajjar merged 2 commits intoros-navigation:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 49 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
Would it be reasonable to add that BT node to this PR to add to the Nav2 library? Seems like it might be a general purpose node. If not, just fix DCO and feel free to merge once done yourself |
SteveMacenski
approved these changes
Dec 25, 2025
Contributor
Author
|
The BT node is our version of IsPathValid, so let's discuss in the ticket if we have them merged into one |
Member
|
Great - we’ll chat there. Fix DCO and feel free to merge once checks pass again. |
Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
910028e to
e82509c
Compare
pele1410
pushed a commit
to Metal-Shark-Sharktech/navigation2
that referenced
this pull request
Dec 30, 2025
* Expose CostmapSubscriber callback_group Signed-off-by: Tony Najjar <tony.najjar@dexory.com> * Expose CostmapSubscriber callback_group for updates Signed-off-by: Tony Najjar <tony.najjar@dexory.com> --------- Signed-off-by: Tony Najjar <tony.najjar@dexory.com> Signed-off-by: Christopher Thompson <cthompson@metalsharkboats.com>
Lotusymt
pushed a commit
to Lotusymt/navigation2
that referenced
this pull request
Jan 16, 2026
* Expose CostmapSubscriber callback_group Signed-off-by: Tony Najjar <tony.najjar@dexory.com> * Expose CostmapSubscriber callback_group for updates Signed-off-by: Tony Najjar <tony.najjar@dexory.com> --------- Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Pana1v
pushed a commit
to Arnav-panjla/navigation2
that referenced
this pull request
Feb 21, 2026
* Expose CostmapSubscriber callback_group Signed-off-by: Tony Najjar <tony.najjar@dexory.com> * Expose CostmapSubscriber callback_group for updates Signed-off-by: Tony Najjar <tony.najjar@dexory.com> --------- Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My motivation for exposing the callback group as an input is to spin that node independently within a BT node:
(pseudo-code)