Skip to content

Expose CostmapSubscriber's callback group#5810

Merged
tonynajjar merged 2 commits intoros-navigation:mainfrom
botsandus:expose-callback-group
Dec 29, 2025
Merged

Expose CostmapSubscriber's callback group#5810
tonynajjar merged 2 commits intoros-navigation:mainfrom
botsandus:expose-callback-group

Conversation

@tonynajjar
Copy link
Copy Markdown
Contributor

@tonynajjar tonynajjar commented Dec 23, 2025

My motivation for exposing the callback group as an input is to spin that node independently within a BT node:

(pseudo-code)

  callback_group_ = node_->create_callback_group(
    rclcpp::CallbackGroupType::MutuallyExclusive,
    false);
  callback_group_executor_.add_callback_group(callback_group_, node_->get_node_base_interface());
  costmap_sub_ = std::make_shared<nav2_costmap_2d::CostmapSubscriber>(
    node_, costmap_topic, callback_group_);
  callback_group_executor_.spin_all(bt_loop_duration_);

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
..._2d/include/nav2_costmap_2d/costmap_subscriber.hpp 100.00% <100.00%> (ø)

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented Dec 25, 2025

Would it be reasonable to add that BT node to this PR to add to the Nav2 library? Seems like it might be a general purpose node.

If not, just fix DCO and feel free to merge once done yourself

@tonynajjar
Copy link
Copy Markdown
Contributor Author

#5808

The BT node is our version of IsPathValid, so let's discuss in the ticket if we have them merged into one

@SteveMacenski
Copy link
Copy Markdown
Member

Great - we’ll chat there. Fix DCO and feel free to merge once checks pass again.

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
@tonynajjar tonynajjar force-pushed the expose-callback-group branch from 910028e to e82509c Compare December 27, 2025 13:49
@tonynajjar tonynajjar merged commit ef9f9f5 into ros-navigation:main Dec 29, 2025
16 checks passed
@tonynajjar tonynajjar deleted the expose-callback-group branch December 29, 2025 09:33
pele1410 pushed a commit to Metal-Shark-Sharktech/navigation2 that referenced this pull request Dec 30, 2025
* Expose CostmapSubscriber callback_group

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>

* Expose CostmapSubscriber callback_group for updates

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>

---------

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Signed-off-by: Christopher Thompson <cthompson@metalsharkboats.com>
Lotusymt pushed a commit to Lotusymt/navigation2 that referenced this pull request Jan 16, 2026
* Expose CostmapSubscriber callback_group

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>

* Expose CostmapSubscriber callback_group for updates

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>

---------

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Pana1v pushed a commit to Arnav-panjla/navigation2 that referenced this pull request Feb 21, 2026
* Expose CostmapSubscriber callback_group

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>

* Expose CostmapSubscriber callback_group for updates

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>

---------

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants