Backport RouteTool RViz plugin to Jazzy (#5663) #5727
Merged
SteveMacenski merged 6 commits intoros-navigation:jazzyfrom Dec 1, 2025
Merged
Backport RouteTool RViz plugin to Jazzy (#5663) #5727SteveMacenski merged 6 commits intoros-navigation:jazzyfrom
SteveMacenski merged 6 commits intoros-navigation:jazzyfrom
Conversation
Contributor
|
@Prathmesh2931, all pull requests must be targeted towards the |
Adds the RouteTool panel to nav2_rviz_plugins for creating and editing route graphs in RViz2. Changes: - Add route_tool.hpp/cpp with Jazzy-compatible namespaces - Add nav2_route dependency to nav2_rviz_plugins - Fix nav2_route include export paths - Add UI resources and launch files for RouteTool Jazzy compatibility fixes: - Use nav2_util::LifecycleNode instead of nav2::LifecycleNode - Use rclcpp::Subscription instead of nav2::Subscription Tested: Builds successfully, plugin loads in RViz2 Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com>
Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com>
Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com>
Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Author
|
Hi maintainers, I've addressed all the linting and DCO issues. All checks are now passing. Thanks! |
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
I assume you have tested all the features of this to verify that it works as expected?
Any notable changes in this file from the version in main so I can focus my review on areas that have diffs? Perhaps in brief bullets let me know what you changed in the route_tool.hpp/cpp files.
Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com>
mini-1235
requested changes
Nov 27, 2025
Collaborator
mini-1235
left a comment
mini-1235
left a comment
There was a problem hiding this comment.
Please also rename the PR title
Otherwise LGTM as long as everything works correctly on your side
Author
@mini-1235 , I have fully tested out changes on rviz2 which you mentioned earlier and these is snapshot in regard of RouteTool plugin by adding node (0,0) .
|
Prathmesh2931
changed the title
mini-1235
reviewed
Dec 1, 2025
- Changed nav2::LifecycleNode to nav2_util::LifecycleNode (correct namespace for jazzy) - Fixed plugins_description.xml: changed base_class_type from rviz_common::Tool to rviz_common::Panel Tested in RViz - plugin loads correctly and creates route graph nodes/edges. Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com>
Author
|
@SteveMacenski , |
SteveMacenski
approved these changes
Dec 1, 2025
redvinaa
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Mar 2, 2026
…avigation#5727) * Backport RouteTool RViz plugin to Jazzy (ros-navigation#5663) Adds the RouteTool panel to nav2_rviz_plugins for creating and editing route graphs in RViz2. Changes: - Add route_tool.hpp/cpp with Jazzy-compatible namespaces - Add nav2_route dependency to nav2_rviz_plugins - Fix nav2_route include export paths - Add UI resources and launch files for RouteTool Jazzy compatibility fixes: - Use nav2_util::LifecycleNode instead of nav2::LifecycleNode - Use rclcpp::Subscription instead of nav2::Subscription Tested: Builds successfully, plugin loads in RViz2 Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com> * fix Linting: added newline at end of file Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com> * Fix linting: remove blank line at end of Python file Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com> * Fix uncrustify formatting for route_tool files Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com> * Updated nav2_route/CMakeLists.txt to original Jazzy Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com> * Fix RouteTool backport to jazzy - Changed nav2::LifecycleNode to nav2_util::LifecycleNode (correct namespace for jazzy) - Fixed plugins_description.xml: changed base_class_type from rviz_common::Tool to rviz_common::Panel Tested in RViz - plugin loads correctly and creates route graph nodes/edges. Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com> --------- Signed-off-by: Prathmesh Atkale <atkaleprathmesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing newlines at end of route_tool files to pass CI linting checks.