Skip to content

Add Eigen in nav2_map_server#5695

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
mini-1235:fix/eigen
Nov 19, 2025
Merged

Add Eigen in nav2_map_server#5695
SteveMacenski merged 1 commit intoros-navigation:mainfrom
mini-1235:fix/eigen

Conversation

@mini-1235
Copy link
Copy Markdown
Collaborator


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

  • I am having build issues when pulling geometry2 and rviz, so I add the eigen3 dependency which is used in map_io.cpp
  • Also cleanup some unused related to eigen

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mini-1235 mini-1235 marked this pull request as draft November 19, 2025 15:17
@mini-1235 mini-1235 marked this pull request as ready for review November 19, 2025 15:34
@SteveMacenski SteveMacenski merged commit 60f3db2 into ros-navigation:main Nov 19, 2025
13 of 14 checks passed
@mini-1235 mini-1235 deleted the fix/eigen branch November 19, 2025 16:51
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

decwest pushed a commit to decwest/navigation2 that referenced this pull request Dec 10, 2025
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
decwest pushed a commit to decwest/navigation2 that referenced this pull request Dec 11, 2025
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants